test: split out emulation tests (#3581)

puppeteer · Nov 21, 2018 · a181bdd · a181bdd
1 parent a5b1978
commit a181bdd
Show file tree

Hide file tree

Showing 3 changed files with 120 additions and 94 deletions.
diff --git a/test/emulation.spec.js b/test/emulation.spec.js
@@ -0,0 +1,119 @@
+/**
+ * Copyright 2018 Google Inc. All rights reserved.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+const utils = require('./utils');
+const DeviceDescriptors = utils.requireRoot('DeviceDescriptors');
+const iPhone = DeviceDescriptors['iPhone 6'];
+const iPhoneLandscape = DeviceDescriptors['iPhone 6 landscape'];
+
+module.exports.addTests = function({testRunner, expect, product}) {
+  const {describe, xdescribe, fdescribe} = testRunner;
+  const {it, fit, xit} = testRunner;
+  const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
+
+  describe('Page.viewport', function() {
+    it('should get the proper viewport size', async({page, server}) => {
+      expect(page.viewport()).toEqual({width: 800, height: 600});
+      await page.setViewport({width: 123, height: 456});
+      expect(page.viewport()).toEqual({width: 123, height: 456});
+    });
+    it('should support mobile emulation', async({page, server}) => {
+      await page.goto(server.PREFIX + '/mobile.html');
+      expect(await page.evaluate(() => window.innerWidth)).toBe(800);
+      await page.setViewport(iPhone.viewport);
+      expect(await page.evaluate(() => window.innerWidth)).toBe(375);
+      await page.setViewport({width: 400, height: 300});
+      expect(await page.evaluate(() => window.innerWidth)).toBe(400);
+    });
+    it('should support touch emulation', async({page, server}) => {
+      await page.goto(server.PREFIX + '/mobile.html');
+      expect(await page.evaluate(() => 'ontouchstart' in window)).toBe(false);
+      await page.setViewport(iPhone.viewport);
+      expect(await page.evaluate(() => 'ontouchstart' in window)).toBe(true);
+      expect(await page.evaluate(dispatchTouch)).toBe('Received touch');
+      await page.setViewport({width: 100, height: 100});
+      expect(await page.evaluate(() => 'ontouchstart' in window)).toBe(false);
+
+      function dispatchTouch() {
+        let fulfill;
+        const promise = new Promise(x => fulfill = x);
+        window.ontouchstart = function(e) {
+          fulfill('Received touch');
+        };
+        window.dispatchEvent(new Event('touchstart'));
+
+        fulfill('Did not receive touch');
+
+        return promise;
+      }
+    });
+    it('should be detectable by Modernizr', async({page, server}) => {
+      await page.goto(server.PREFIX + '/detect-touch.html');
+      expect(await page.evaluate(() => document.body.textContent.trim())).toBe('NO');
+      await page.setViewport(iPhone.viewport);
+      await page.goto(server.PREFIX + '/detect-touch.html');
+      expect(await page.evaluate(() => document.body.textContent.trim())).toBe('YES');
+    });
+    it('should detect touch when applying viewport with touches', async({page, server}) => {
+      await page.setViewport({ width: 800, height: 600, hasTouch: true });
+      await page.addScriptTag({url: server.PREFIX + '/modernizr.js'});
+      expect(await page.evaluate(() => Modernizr.touchevents)).toBe(true);
+    });
+    it('should support landscape emulation', async({page, server}) => {
+      await page.goto(server.PREFIX + '/mobile.html');
+      expect(await page.evaluate(() => screen.orientation.type)).toBe('portrait-primary');
+      await page.setViewport(iPhoneLandscape.viewport);
+      expect(await page.evaluate(() => screen.orientation.type)).toBe('landscape-primary');
+      await page.setViewport({width: 100, height: 100});
+      expect(await page.evaluate(() => screen.orientation.type)).toBe('portrait-primary');
+    });
+  });
+
+  describe('Page.emulate', function() {
+    it('should work', async({page, server}) => {
+      await page.goto(server.PREFIX + '/mobile.html');
+      await page.emulate(iPhone);
+      expect(await page.evaluate(() => window.innerWidth)).toBe(375);
+      expect(await page.evaluate(() => navigator.userAgent)).toContain('Safari');
+    });
+    it('should support clicking', async({page, server}) => {
+      await page.emulate(iPhone);
+      await page.goto(server.PREFIX + '/input/button.html');
+      const button = await page.$('button');
+      await page.evaluate(button => button.style.marginTop = '200px', button);
+      await button.click();
+      expect(await page.evaluate(() => result)).toBe('Clicked');
+    });
+  });
+
+  describe('Page.emulateMedia', function() {
+    it('should work', async({page, server}) => {
+      expect(await page.evaluate(() => window.matchMedia('screen').matches)).toBe(true);
+      expect(await page.evaluate(() => window.matchMedia('print').matches)).toBe(false);
+      await page.emulateMedia('print');
+      expect(await page.evaluate(() => window.matchMedia('screen').matches)).toBe(false);
+      expect(await page.evaluate(() => window.matchMedia('print').matches)).toBe(true);
+      await page.emulateMedia(null);
+      expect(await page.evaluate(() => window.matchMedia('screen').matches)).toBe(true);
+      expect(await page.evaluate(() => window.matchMedia('print').matches)).toBe(false);
+    });
+    it('should throw in case of bad argument', async({page, server}) => {
+      let error = null;
+      await page.emulateMedia('bad').catch(e => error = e);
+      expect(error.message).toBe('Unsupported media type: bad');
+    });
+  });
+};
diff --git a/test/page.spec.js b/test/page.spec.js
@@ -21,7 +21,6 @@ const {TimeoutError} = utils.requireRoot('Errors');
 
 const DeviceDescriptors = utils.requireRoot('DeviceDescriptors');
 const iPhone = DeviceDescriptors['iPhone 6'];
-const iPhoneLandscape = DeviceDescriptors['iPhone 6 landscape'];
 
 let asyncawait = true;
 try {
@@ -1373,99 +1372,6 @@ module.exports.addTests = function({testRunner, expect, headless}) {
     });
   });
 
-  describe('Page.viewport', function() {
-    it('should get the proper viewport size', async({page, server}) => {
-      expect(page.viewport()).toEqual({width: 800, height: 600});
-      await page.setViewport({width: 123, height: 456});
-      expect(page.viewport()).toEqual({width: 123, height: 456});
-    });
-    it('should support mobile emulation', async({page, server}) => {
-      await page.goto(server.PREFIX + '/mobile.html');
-      expect(await page.evaluate(() => window.innerWidth)).toBe(800);
-      await page.setViewport(iPhone.viewport);
-      expect(await page.evaluate(() => window.innerWidth)).toBe(375);
-      await page.setViewport({width: 400, height: 300});
-      expect(await page.evaluate(() => window.innerWidth)).toBe(400);
-    });
-    it('should support touch emulation', async({page, server}) => {
-      await page.goto(server.PREFIX + '/mobile.html');
-      expect(await page.evaluate(() => 'ontouchstart' in window)).toBe(false);
-      await page.setViewport(iPhone.viewport);
-      expect(await page.evaluate(() => 'ontouchstart' in window)).toBe(true);
-      expect(await page.evaluate(dispatchTouch)).toBe('Received touch');
-      await page.setViewport({width: 100, height: 100});
-      expect(await page.evaluate(() => 'ontouchstart' in window)).toBe(false);
-
-      function dispatchTouch() {
-        let fulfill;
-        const promise = new Promise(x => fulfill = x);
-        window.ontouchstart = function(e) {
-          fulfill('Received touch');
-        };
-        window.dispatchEvent(new Event('touchstart'));
-
-        fulfill('Did not receive touch');
-
-        return promise;
-      }
-    });
-    it('should be detectable by Modernizr', async({page, server}) => {
-      await page.goto(server.PREFIX + '/detect-touch.html');
-      expect(await page.evaluate(() => document.body.textContent.trim())).toBe('NO');
-      await page.setViewport(iPhone.viewport);
-      await page.goto(server.PREFIX + '/detect-touch.html');
-      expect(await page.evaluate(() => document.body.textContent.trim())).toBe('YES');
-    });
-    it('should detect touch when applying viewport with touches', async({page, server}) => {
-      await page.setViewport({ width: 800, height: 600, hasTouch: true });
-      await page.addScriptTag({url: server.PREFIX + '/modernizr.js'});
-      expect(await page.evaluate(() => Modernizr.touchevents)).toBe(true);
-    });
-    it('should support landscape emulation', async({page, server}) => {
-      await page.goto(server.PREFIX + '/mobile.html');
-      expect(await page.evaluate(() => screen.orientation.type)).toBe('portrait-primary');
-      await page.setViewport(iPhoneLandscape.viewport);
-      expect(await page.evaluate(() => screen.orientation.type)).toBe('landscape-primary');
-      await page.setViewport({width: 100, height: 100});
-      expect(await page.evaluate(() => screen.orientation.type)).toBe('portrait-primary');
-    });
-  });
-
-  describe('Page.emulate', function() {
-    it('should work', async({page, server}) => {
-      await page.goto(server.PREFIX + '/mobile.html');
-      await page.emulate(iPhone);
-      expect(await page.evaluate(() => window.innerWidth)).toBe(375);
-      expect(await page.evaluate(() => navigator.userAgent)).toContain('Safari');
-    });
-    it('should support clicking', async({page, server}) => {
-      await page.emulate(iPhone);
-      await page.goto(server.PREFIX + '/input/button.html');
-      const button = await page.$('button');
-      await page.evaluate(button => button.style.marginTop = '200px', button);
-      await button.click();
-      expect(await page.evaluate(() => result)).toBe('Clicked');
-    });
-  });
-
-  describe('Page.emulateMedia', function() {
-    it('should work', async({page, server}) => {
-      expect(await page.evaluate(() => window.matchMedia('screen').matches)).toBe(true);
-      expect(await page.evaluate(() => window.matchMedia('print').matches)).toBe(false);
-      await page.emulateMedia('print');
-      expect(await page.evaluate(() => window.matchMedia('screen').matches)).toBe(false);
-      expect(await page.evaluate(() => window.matchMedia('print').matches)).toBe(true);
-      await page.emulateMedia(null);
-      expect(await page.evaluate(() => window.matchMedia('screen').matches)).toBe(true);
-      expect(await page.evaluate(() => window.matchMedia('print').matches)).toBe(false);
-    });
-    it('should throw in case of bad argument', async({page, server}) => {
-      let error = null;
-      await page.emulateMedia('bad').catch(e => error = e);
-      expect(error.message).toBe('Unsupported media type: bad');
-    });
-  });
-
   describe('Page.setJavaScriptEnabled', function() {
     it('should work', async({page, server}) => {
       await page.setJavaScriptEnabled(false);

diff --git a/test/test.js b/test/test.js
@@ -157,6 +157,7 @@ describe('Browser', function() {
     require('./jshandle.spec.js').addTests({testRunner, expect});
     require('./network.spec.js').addTests({testRunner, expect});
     require('./page.spec.js').addTests({testRunner, expect, headless});
+    require('./emulation.spec.js').addTests({testRunner, expect, headless});
     require('./screenshot.spec.js').addTests({testRunner, expect});
     require('./target.spec.js').addTests({testRunner, expect});
     require('./tracing.spec.js').addTests({testRunner, expect});