Skip to content

Commit

Permalink
feat(chromium): roll Chromium to r604907 (#3488)
Browse files Browse the repository at this point in the history
Also, new Chrome now exposes a new type in its protocol - binary.
It becomes a raw C++ array once used through C++ bindings, but for
us it's still a base64 string.
  • Loading branch information
aslushnikov committed Nov 3, 2018
1 parent 6b65407 commit 52a1030
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -8,7 +8,7 @@
"node": ">=6.4.0"
},
"puppeteer": {
"chromium_revision": "599821"
"chromium_revision": "604907"
},
"scripts": {
"unit": "node test/test.js",
Expand Down
3 changes: 2 additions & 1 deletion utils/protocol-types-generator/index.js
Expand Up @@ -13,6 +13,7 @@ module.exports = puppeteer.launch({
const version = await browser.version();
await browser.close();
const output = `// This is generated from /utils/protocol-types-generator/index.js
type binary = string;
declare global {
module Protocol {${json.domains.map(domain => `${domain.description ? `
/**
Expand Down Expand Up @@ -101,4 +102,4 @@ function typeOfProperty(property, domain) {
return 'number';
}
return property.type;
}
}

0 comments on commit 52a1030

Please sign in to comment.