Skip to content

Commit

Permalink
feat(chromium): roll Chromium to r588429 (#3181)
Browse files Browse the repository at this point in the history
This roll includes:
- https://crrev.com/588420 - DevTools: teach request interception to work with
  Security.setIgnoreCertificateErrors

Fixes #1159.
  • Loading branch information
aslushnikov committed Sep 4, 2018
1 parent 464f3b4 commit 32c0363
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -8,7 +8,7 @@
"node": ">=6.4.0"
},
"puppeteer": {
"chromium_revision": "587164"
"chromium_revision": "588429"
},
"scripts": {
"unit": "node test/test.js",
Expand Down
6 changes: 6 additions & 0 deletions test/ignorehttpserrors.spec.js
Expand Up @@ -55,6 +55,12 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions})
const securityDetails = responses[0].securityDetails();
expect(securityDetails.protocol()).toBe('TLS 1.2');
});
it('should work with request interception', async({page, server, httpsServer}) => {
await page.setRequestInterception(true);
page.on('request', request => request.continue());
const response = await page.goto(httpsServer.EMPTY_PAGE);
expect(response.status()).toBe(200);
});
it('should work with mixed content', async({page, server, httpsServer}) => {
httpsServer.setRoute('/mixedcontent.html', (req, res) => {
res.end(`<iframe src=${server.EMPTY_PAGE}></iframe>`);
Expand Down

0 comments on commit 32c0363

Please sign in to comment.