test: split out navigation tests (#3585)

puppeteer · Nov 21, 2018 · 309cbe6 · 309cbe6
1 parent d61916b
commit 309cbe6
Show file tree

Hide file tree

Showing 4 changed files with 508 additions and 484 deletions.
diff --git a/test/frame.spec.js b/test/frame.spec.js
@@ -48,84 +48,6 @@ module.exports.addTests = function({testRunner, expect}) {
     });
   });
 
-  describe('Frame.goto', function() {
-    it('should navigate subframes', async({page, server}) => {
-      await page.goto(server.PREFIX + '/frames/one-frame.html');
-      expect(page.frames()[0].url()).toContain('/frames/one-frame.html');
-      expect(page.frames()[1].url()).toContain('/frames/frame.html');
-
-      const response = await page.frames()[1].goto(server.EMPTY_PAGE);
-      expect(response.ok()).toBe(true);
-      expect(response.frame()).toBe(page.frames()[1]);
-    });
-    it('should reject when frame detaches', async({page, server}) => {
-      await page.goto(server.PREFIX + '/frames/one-frame.html');
-
-      server.setRoute('/empty.html', () => {});
-      const navigationPromise = page.frames()[1].goto(server.EMPTY_PAGE).catch(e => e);
-      await server.waitForRequest('/empty.html');
-
-      await page.$eval('iframe', frame => frame.remove());
-      const error = await navigationPromise;
-      expect(error.message).toBe('Navigating frame was detached');
-    });
-    it('should return matching responses', async({page, server}) => {
-      // Disable cache: otherwise, chromium will cache similar requests.
-      await page.setCacheEnabled(false);
-      await page.goto(server.EMPTY_PAGE);
-      // Attach three frames.
-      const frames = await Promise.all([
-        utils.attachFrame(page, 'frame1', server.EMPTY_PAGE),
-        utils.attachFrame(page, 'frame2', server.EMPTY_PAGE),
-        utils.attachFrame(page, 'frame3', server.EMPTY_PAGE),
-      ]);
-      // Navigate all frames to the same URL.
-      const serverResponses = [];
-      server.setRoute('/one-style.html', (req, res) => serverResponses.push(res));
-      const navigations = [];
-      for (let i = 0; i < 3; ++i) {
-        navigations.push(frames[i].goto(server.PREFIX + '/one-style.html'));
-        await server.waitForRequest('/one-style.html');
-      }
-      // Respond from server out-of-order.
-      const serverResponseTexts = ['AAA', 'BBB', 'CCC'];
-      for (const i of [1, 2, 0]) {
-        serverResponses[i].end(serverResponseTexts[i]);
-        const response = await navigations[i];
-        expect(response.frame()).toBe(frames[i]);
-        expect(await response.text()).toBe(serverResponseTexts[i]);
-      }
-    });
-  });
-
-  describe('Frame.waitForNavigation', function() {
-    it('should work', async({page, server}) => {
-      await page.goto(server.PREFIX + '/frames/one-frame.html');
-      const frame = page.frames()[1];
-      const [response] = await Promise.all([
-        frame.waitForNavigation(),
-        frame.evaluate(url => window.location.href = url, server.PREFIX + '/grid.html')
-      ]);
-      expect(response.ok()).toBe(true);
-      expect(response.url()).toContain('grid.html');
-      expect(response.frame()).toBe(frame);
-      expect(page.url()).toContain('/frames/one-frame.html');
-    });
-    it('should reject when frame detaches', async({page, server}) => {
-      await page.goto(server.PREFIX + '/frames/one-frame.html');
-      const frame = page.frames()[1];
-
-      server.setRoute('/empty.html', () => {});
-      const navigationPromise = frame.waitForNavigation();
-      await Promise.all([
-        server.waitForRequest('/empty.html'),
-        frame.evaluate(() => window.location = '/empty.html')
-      ]);
-      await page.$eval('iframe', frame => frame.remove());
-      await navigationPromise;
-    });
-  });
-
   describe('Frame.evaluateHandle', function() {
     it('should work', async({page, server}) => {
       await page.goto(server.EMPTY_PAGE);