From 161519a60dea58afc5f42f450925b966da05ffcb Mon Sep 17 00:00:00 2001 From: Patrick Hulce Date: Fri, 11 Jan 2019 12:02:22 -0800 Subject: [PATCH] core: stricter LR-desktop metric scoring (#6969) --- lighthouse-cli/cli-flags.js | 1 - lighthouse-core/config/lr-desktop-config.js | 13 +++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/lighthouse-cli/cli-flags.js b/lighthouse-cli/cli-flags.js index 6aefa4edbbdb..d366eb918acc 100644 --- a/lighthouse-cli/cli-flags.js +++ b/lighthouse-cli/cli-flags.js @@ -137,7 +137,6 @@ function getFlags(manualArgv) { // default values .default('chrome-flags', '') .default('output', ['html']) - .default('emulated-form-factor', 'mobile') .default('port', 0) .default('hostname', 'localhost') .default('enable-error-reporting', undefined) // Undefined so prompted by default diff --git a/lighthouse-core/config/lr-desktop-config.js b/lighthouse-core/config/lr-desktop-config.js index 36ba73592b30..11fc64485e0e 100644 --- a/lighthouse-core/config/lr-desktop-config.js +++ b/lighthouse-core/config/lr-desktop-config.js @@ -21,6 +21,19 @@ const config = { // Skip the h2 audit so it doesn't lie to us. See #6539 skipAudits: ['uses-http2'], }, + audits: [ + // 75th and 95th percentiles -> median and PODR + // SELECT QUANTILES(renderStart, 21) FROM [httparchive:summary_pages.2018_12_15_desktop] LIMIT 1000 + {path: 'metrics/first-contentful-paint', options: {scorePODR: 800, scoreMedian: 1600}}, + {path: 'metrics/first-meaningful-paint', options: {scorePODR: 800, scoreMedian: 1600}}, + // 75th and 95th percentiles -> median and PODR + // SELECT QUANTILES(SpeedIndex, 21) FROM [httparchive:summary_pages.2018_12_15_desktop] LIMIT 1000 + {path: 'metrics/speed-index', options: {scorePODR: 1100, scoreMedian: 2300}}, + // 75th and 95th percentiles -> median and PODR + // SELECT QUANTILES(fullyLoaded, 21) FROM [httparchive:summary_pages.2018_12_15_desktop] LIMIT 1000 + {path: 'metrics/interactive', options: {scorePODR: 2000, scoreMedian: 4500}}, + {path: 'metrics/first-cpu-idle', options: {scorePODR: 2000, scoreMedian: 4500}}, + ], }; module.exports = config;