Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AnyComponent instead of ComponentFactory in `mountJsx #166

Closed
keichinger opened this issue Jan 16, 2019 · 1 comment
Closed

Use AnyComponent instead of ComponentFactory in `mountJsx #166

keichinger opened this issue Jan 16, 2019 · 1 comment
Labels
bug

Comments

@keichinger
Copy link
Contributor

With Preact 8.4.0 (see PR preactjs/preact#1249) we should no switch over to AnyComponent instead of ComponentFactory<T> in order to fix compatibility.

Pretty sure that using ComponentFactory<T> was never intended to be used outside of Preact itself.
@keichinger keichinger added the bug label Jan 16, 2019
@apfelbox
Copy link
Contributor

apfelbox commented Jan 17, 2019 •
edited

As we saw this is not correct – as h() still (correctly) expects a ComponentFactory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@keichinger @apfelbox