Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sites sidebar: Improve responsiveness of tooltips #90624

Merged
merged 1 commit into from May 14, 2024
Merged

Sites sidebar: Improve responsiveness of tooltips #90624

merged 1 commit into from May 14, 2024

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented May 13, 2024

Fixes #90619

Proposed Changes

Fixes a couple of regressions introduced in #90429 which caused the tooltips to be slightly broken at certain viewports.

Before After
Screenshot 2024-05-13 at 13 08 30 Screenshot 2024-05-13 at 13 08 36
Screenshot 2024-05-13 at 13 08 57 Screenshot 2024-05-13 at 13 24 05

Testing Instructions

  • Use the Calypso live link below
  • Go to /sites and select a site
  • Check that the tooltips are no longer displayed at viewports below 660px
  • Check that the tooltips are displayed correctly at viewports between 661px and 782px

@mmtr mmtr requested a review from a team May 13, 2024 11:26
@mmtr mmtr self-assigned this May 13, 2024
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 13, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 13, 2024 •
edited by matticbot

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-107389
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-107389&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-107389&env=a8c-for-agencies

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/sites-sidebar-tooltips on your sandbox.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

dsas
dsas reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@dsas dsas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine that 'Sites' etc no longer have a repetitive toolip, but is it correct that the e.g. the command palette doesn't? I don't get what was broken about about the me/help/palette/notifications tooltips.

davemart-in
davemart-in approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@davemart-in davemart-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. It's fixed in my testing.

taipeicoder
taipeicoder approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 👍

@taipeicoder taipeicoder merged commit 654a8f9 into trunk May 14, 2024
13 of 14 checks passed
@taipeicoder taipeicoder deleted the fix/sites-sidebar-tooltips branch May 14, 2024 01:31
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsas dsas dsas left review comments

@taipeicoder taipeicoder taipeicoder approved these changes

@davemart-in davemart-in davemart-in approved these changes

Assignees

@mmtr mmtr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mobile menu slightly broken on sites page
5 participants
@mmtr @matticbot @dsas @taipeicoder @davemart-in